Re: [PATCH 6/5] sequencer.c: refrain from adding duplicate s-o-b lines

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 16, 2012, 02:03 UTC
Message-ID: <7v4nkq8fsn.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1353021875-7552-1-git-send-email-drafnel@gmail.com>

Brandon Casey <drafnel@gmail.com> writes:

> Detect whether the s-o-b already exists in the commit footer and refrain
> from adding a duplicate.

If you are trying to forbid

	git cherry-pick -s $other

from adding s-o-b: A when $other ends with these two existing s-o-b:

	s-o-b: A
	s-o-b: B

then I think that is a wrong thing to do.

In such a case, the resulting commit should gain another s-o-b from A to record the provenance as a chain of events. A originally wrote the patch, B forwarded it (possibly with his own tweaks), and then A picked it up and recorded the result to the history, possibly with a final tweak or two.