Re: [RFC/PATCH 1/2] reset: learn to reset to tree
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 29, 2012, 18:47 UTC
- Message-ID
- <7v4nk8qmaj.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1354213975-17866-2-git-send-email-martinvonz@gmail.com>
Martin von Zweigbergk <martinvonz@gmail.com> writes:
Show 5 quoted lines
> In cases where HEAD is not supposed to be updated, there is no reason
> that "git reset" should require a commit, a tree should be enough. So
> make "git reset $rev^{tree}" work just like "git reset $rev", except
> that the former will not update HEAD (since there is no commit to
> point it to).That is a horrible design I have to nack, unless you require pathspec. You cannot tell what "git reset $sha1" would do without checking the type of the object $sha1 refers to. If you do this only when pathspec is present, then the design is very reasonable.
> Disallow --soft with trees, since that is about updating only HEAD.
Likewise.