Re: [RFC] The design of new pathspec features

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 29, 2013, 06:31 UTC
Message-ID: <7v4ni0ts90.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CACsJy8DsKFfGoPUt5b=3MuSmZ2z2Z5vJ20D_kqEowAUc8QTryA@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

Show 8 quoted lines

>>         prefixq=$(git rev-parse --show-prefix-glob-quoted)
>>         pathspec="$prefixq$1"
>>
>> but magic that applies only to a substring may have other uses.
>
> Yeah, that simplifies things. Supporting applying magic over just
> parts of the pathspec pattern sounds complex. Just a small
> modification. That rev-parse needs to look at "$1" as well.

Makes sense.  More like

	prefix=$(git rev-parse --show-prefix)
	test -z "$prefix" || cd $(git rev-parse --show-cdup)
	...
	pathspec=$(git rev-parse --prefix-pathspec "$prefix" "$1")
	git ls-files "$pathspec"

which may take prefix="D*cumentati*n" (from the previous example), and the user may have given ":(icase)hell*.txt" to "$1". Ideally the scriptors shouldn't have to worry about how to add the prefix to the user supplied pathspec.