Re: [PATCH v2 3/6] transport-helper: clarify pushing without refspecs

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 19, 2013, 03:41 UTC
Message-ID: <7v4nf34276.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAPig+cRp7J+HYBA=2OL-CdA3NiQFjuUMZEjE+i+SnNrrPBAZ6Q@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

>> +       grep "remote-helper doesn.t support push; refspec needed" error
>
> Is "doesn.t" intentional? It certainly works by accident in grep, but
> did you mean s/doesn.t/doesn't/ ?

The pattern matching the expected string is not by accident, but by design.

It of course can be made more strict to reject "doesnot" and require "doesn't" by doing something like this:

       grep "remote-helper doesn'\''t support push; refspec needed" error

but at some point, it simply stops being worth it to tighten the pattern.

For that matter, it could be as loose as

	grep "support push; refspec needed" error

if you know the string is unique enough.