Re: [PATCH v3 0/6] git send-email suppress-cc=self fixes

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 4, 2013, 22:11 UTC
Message-ID: <7v4ndd5xwp.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130604214921.GA30400@redhat.com>

"Michael S. Tsirkin" <mst@redhat.com> writes:

Show 7 quoted lines

> All I see in 2/6 is this:
>
> 	diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
> 	index e1a7f3e..f81e5f5 100755
> 	--- a/t/t9001-send-email.sh
> 	+++ b/t/t9001-send-email.sh
> 	@@ -204,13 +204,15 @@ test_suppress_self_unquoted () {

After noticing what is after "@@" here...

Show 17 quoted lines

>
> 			unquoted-$3
>
> 	+               cccmd--$1 <$2>
> 	+
> 			Cc: $1 <$2>
> 			Signed-off-by: $1 <$2>
> 		EOF
> 	 }
>
> 	 test_expect_success $PREREQ 'self name is suppressed' "
> 	-       test_suppress_self_unquoted 'A U Thor' 'author@redhat.com' \
> 	+       test_suppress_self_unquoted 'A U Thor' 'author@example.com' \
> 			'self_name_suppressed'
> 	 "
>
> where's test_suppress_self_quoted here?

... isn't addition of "cccmd--$1 <$2>" made to that function?

After applying [PATCH v3 1/6] to 'master', I do not see unquoted-$3 that we see in the context, either.

"git grep unquoted- pu t/t9001*" does show us a hit, but that is coming from your previous round you are replacing with this series, so....

Confused...