Re: [PATCH v5] [submodule] Add --depth to submodule update/add

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 3, 2013, 08:13 UTC
Message-ID: <7v4ncchxif.fsf@alter.siamese.dyndns.org>
In-Reply-To: <51D3D20A.5000700@web.de>

Jens Lehmann <Jens.Lehmann@web.de> writes:

Show 20 quoted lines

> Am 02.07.2013 23:42, schrieb Fredrik Gustafsson:
>> Add the --depth option to the add and update commands of "git submodule",
>> which is then passed on to the clone command. This is useful when the
>> submodule(s) are huge and you're not really interested in anything but
>> the latest commit.
>> 
>> Tests are added and some indention adjustments were made to conform to the
>> rest of the testfile on "submodule update can handle symbolic links in pwd".
>> 
>> Signed-off-by: Fredrik Gustafsson <iveqy@iveqy.com>
>> ---
>> 
>> And I finally thought I'd everything right. I appriciate your reviews.
>> 
>> I left the "" on $5 for consistency as suggested.
>
> Thanks, looking good to me. Passes all tests and the new tests fail
> when the change in the submodule script is reverted.
>
> Acked-by: Jens Lehmann <Jens.Lehmann@web.de>

> The only minor problem is that this patch still does not apply cleanly
> to master, next or pu (I wonder what you based this on ;-).

Thanks; will replace what I queued on 'pu'.