Re: auto-packing on kernel.org? please?
- From
Junio C Hamano <junkio@cox.net>
- Date
- Nov 21, 2005, 19:58 UTC
- Message-ID
- <7v3blprcwk.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.64.0511211110480.13959@g5.osdl.org>
Linus Torvalds <torvalds@osdl.org> writes:
Show 11 quoted lines
> Can anybody tell me how to do that sanely? Right now we do > > .. > name=$(git-rev-list --objects $rev_list $(git-rev-parse $rev_parse) | > git-pack-objects --non-empty $pack_objects .tmp-pack) || > exit 1 > .. > > and the thing is, the "git-pack-objects" thing is happy, it's the > "git-rev-list" that fails. So because the last command in the pipeline > returns ok, we think it all is ok..
One cop-out: do fsck-objects upfront before making a pack. This would populate your buffer cache so it might not be a bad thing.
Alternatively:
name=$( {
git-rev-list --objects $rev_list $(git-rev-parse $rev_parse) ||
echo Gaaahhh
} | git-pack-objects --non-empty $pack_objects .tmp-pack)