git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-bisect problem

From
Junio C Hamano <junkio@cox.net>
Date
Feb 14, 2006, 00:33 UTC
Message-ID
<7v3bimzsn2.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20060213015146.26e6c09d.akpm@osdl.org>
Andrew Morton <akpm@osdl.org> writes:
> git-format-patch -o ~/a 386093ef9a6c88576d8b418bf1c8616d5e410a20 git-netdev-all
>
> and that chewed 10 minutes CPU time and produced no output, so I killed it.
A single commit is either:
	git format-patch -o ~/a 386093^ 386093
	git show 386093

But if you _did_ want to get everything that builds on top of 386093 (and Linus counted 1000+ commits if I recall), format-patch could be optimized. It currently does a lot more than just format 1000+ commits, to handle case where "his" and "mine" are not linear history and may have the same change acquired by applying the same patch:

          1---2---3 mine
         /
     ---4---5---6 his

In this picture, it does not just format 1 2 3. It first checks 1 2 3 5 6, and if each of 1 2 3 introduces the same change as either 5 or 6 introduces to omit it from the output. If 2 and 5 are the same change from 1 and 4 respectively, the final result has 1 and 3. This is OK and useful for smaller branch, but clearly expensive for long branches.

This is omitted when the ancestry graph would look like this:
	
          1---2---3 mine
         /
     ---4 his
but that would not have helped in this case anyway.

Maybe we could have --no-omit-common flag or something to disable this check.

Previous: Andrew MortonNext: Junio C Hamano
Message 15 of 23 in “git-bisect problem”
  1. Andrew MortonFeb 13, 2006
  2. Junio C HamanoFeb 13, 2006
  3. Andrew MortonFeb 13, 2006
  4. Ryan AndersonFeb 13, 2006
  5. Andrew MortonFeb 13, 2006
  6. Fernando J. PeredaFeb 13, 2006
  7. Luben TuikovFeb 13, 2006
  8. Luben TuikovFeb 13, 2006
  9. cat-file (was Re: git-bisect problem)Joshua N Pritikin, Feb 13, 2006
  10. Ryan AndersonFeb 13, 2006
  11. Andrew MortonFeb 13, 2006
  12. Linus TorvaldsFeb 13, 2006
  13. Luben TuikovFeb 13, 2006
  14. Andrew MortonFeb 13, 2006
  15. Junio C HamanoFeb 14, 2006
  16. Junio C HamanoFeb 13, 2006
  17. Andrew MortonFeb 13, 2006
  18. Junio C HamanoFeb 14, 2006
  19. Andrew MortonFeb 14, 2006
  20. Linus TorvaldsFeb 14, 2006
  21. Petr BaudisFeb 14, 2006
  22. Petr BaudisFeb 14, 2006
  23. Junio C HamanoFeb 14, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.