Re: [PATCH (resend)] gitweb: Fix bug in "blobdiff" view for split (e.g. file to symlink) patches

From: Junio C Hamano <junkio@cox.net>
Date: Apr 5, 2007, 20:47 UTC
Message-ID: <7v3b3epn0a.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <1175773541251-git-send-email-jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

Show 6 quoted lines

> git_patchset_body needs patch generated with --full-index option to
> detect split patches,...
> ...
> This patch fixes this bug in git_blobdiff (in "blobdiff" view).
>
> Junio, you probably have missed this patch in the noise...

Probably. Although I do remember seeing the patch, it was unclear why --full-index is needed (and it still is unclear to me). Do you have a parser that expects/depends on full 40-hexdigit hash on the index line?

Not a complaint but a question -- I do not mind (actually prefer, probably) if gitweb worked on full 40-hexdigit internally to avoid possible ambiguity issues, although the output may need to be truncated to save people from having to see unneeded precision.