git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 5/8] get-repack --max-pack-size: write_object() takes 'limit' arg

From
Junio C Hamano <junkio@cox.net>
Date
Apr 9, 2007, 20:09 UTC
Message-ID
<7v3b39z4vr.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<56b7f5510704091220w69529e72n2f982c097c4e26a0@mail.gmail.com>
"Dana How" <danahow@gmail.com> writes:
> For testing, I've been using git-fsck/git-verify-pack/git-unpack-objects .

Among the above, verify-pack does not do much more than what the normal object reading path does already these days. Also unpack-objects (especially with -n) omits a lot of object integrity checks, and not very appropriate test.

We have some tests for packfiles in t/ (make test) but I would not be surprised if we do not have enough. Most of the existing tests are done on loose objects the tests themselves produce without repacking, because their focus is not about packs and they test whatever they are interested in, assuming that the lowest level object layer is correctly functioning.

Previous: Nicolas Pitre
Message 10 of 10 in “get-repack --max-pack-size: write_object() takes 'limit' arg”
  1. 5/8 get-repack --max-pack-size: write_object() takes 'limit' argDana How, Apr 8, 2007
  2. Junio C HamanoApr 9, 2007
  3. Junio C HamanoApr 9, 2007
  4. Nicolas PitreApr 9, 2007
  5. Nicolas PitreApr 9, 2007
  6. Dana HowApr 9, 2007
  7. Nicolas PitreApr 9, 2007
  8. Dana HowApr 9, 2007
  9. Nicolas PitreApr 9, 2007
  10. Junio C HamanoApr 9, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.