Re: Bug: git-rebase goofs up \n in commit messages
Jeff King <peff@peff.net> writes:
Show 20 quoted lines
> On Fri, May 25, 2007 at 09:59:43PM -0700, Junio C Hamano wrote:
>
>> * I suspect we would declare either "war on echo" or "harder push
>> for builtins" triggered by these.
>
> Cry havoc! More fixes below (just a diff -- maybe we want to aggregate
> these into a single commit?).
>
> These are the ones I noticed that use commit messages (which are
> probably the most likely to use backslash). There are _tons_ of uses for
> heads and filenames. I think we either should stop with commit messages,
> or go all-out and simply remove all uses of echo (because there are
> literally hundreds otherwise).
>
>> - echo "$commit_only" |
>> + printf "%s\n" "$commit_only" |
>
> Is "\n" portable to all shells (i.e., do you need '\n')? It works with
> bash and dash, which are by far the most common, but who knows what evil
> lurks in the heart of Sun?