Re: t7005 and vi in GIT_EXEC_PATH

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 11, 2007, 19:43 UTC
Message-ID: <7v3avcefg9.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <FCFF59B3-D3F1-4BEB-B3C3-D07DD5D5D8EF@silverinsanity.com>

Brian Gernhardt <benji@silverinsanity.com> writes:

Show 12 quoted lines

> I'm sorry, I should have been more clear.  I was referring to the
> GIT_EXEC_PATH build variable, not the environment variable.  The git
> wrapper always adds the path determined during build to the front of
> PATH.  When I was changing my build script, this got set to "/usr/
> local/bin" (I usually use /usr/local/stow/git, instead).  Since I have
> a /usr/local/bin/vim, PATH for git-commit.sh during the test was:
>
> - my git build directory
> - /usr/local/bin (containing a symlink vi -> vim)
> - the t/trash directory, added by the test via `PATH=".:$PATH"`
> (containing the test vi script)
> - my normal path

Maybe that is what is broken. t/test-lib.sh makes the environment variable point at the build directory, and that should override the path that is compiled in, shouldn't it?