git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: config.c fixes

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 14, 2007, 19:43 UTC
Message-ID
<7v3au5rrjv.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20071214192852.GA24187@bitplanet.net>
Kristian Høgsberg <krh@redhat.com> writes:
> While strace'ing builtin-clone I saw this horror:
> I think the best solution is to just parse up the entire config file
> up front and keep it in a data structure, make the changes and then
> write it all out at the end.

Yeah, that was what I suggested a few times when other people have done config writing side, but without successfully getting past their skulls (it is not Linus's nor my code). It's about time somebody started to clean up that mess.

The timing is a bit unfortunate, though. I would have preferred to have a week or so to cook this in 'next' before merging it part of -rc0.

Previous: Kristian HøgsbergNext: Kristian Høgsberg
Message 2 of 3 in “config.c fixes”
  1. Kristian HøgsbergDec 14, 2007
  2. Junio C HamanoDec 14, 2007
  3. Kristian HøgsbergDec 14, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.