Re: setup_path()

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 13, 2008, 20:00 UTC
Message-ID: <7v3arwpqxj.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080213.044915.123319879.davem@davemloft.net>

David Miller <davem@davemloft.net> writes:

Show 10 quoted lines

> Shouldn't stand-alone programs other than git.c itself also call
> setup_path()?
>
> I have a problem where if I only install git into my own home
> directory ~/bin, I can't send pull requests over SSH to that machine
> successfully because the execvp() of "pack-objects" by git-upload-pack
> fails due to the PATH not containing "git --exec-dir"
>
> If I add a dummy setup_path(NULL) call to upload-pack.c, it works
> fine.

Yeah, Johannes Sixt had a patch to do exactly that earlier

	Message-ID: <47B182C1.60006@viscovery.net>
	http://news.gmane.org/gmane.comp.version-control.git/73651

and I think it is a good idea to apply it.