Re: [PATCH] Write diff output to a file in struct diff_options
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 10, 2008, 06:18 UTC
- Message-ID
- <7v3aqzm7ac.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <alpine.LNX.1.00.0803092235150.19665@iabervon.org>
Daniel Barkalow <barkalow@iabervon.org> writes:
Show 7 quoted lines
> Signed-off-by: Daniel Barkalow <barkalow@iabervon.org> > --- > I remember there being some expectation that this would be difficult, but > it was a pretty straightforward conversion, so I'm wondering if I've > missed something. In any case, this is missing tests and documentation for > --output=, but I really want it to use directly for rebase-interactive, > and I only did the command line option so I could do informal testing.
Looks Ok at lesat to my cursory review.
Some people however seemed to have had plans to take this even further and optionally emit into strbuf; I suspect that was the difficulty you were remembering about?