git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] diff options: Introduce --ignore-submodules

From
Junio C Hamano <gitster@pobox.com>
Date
May 15, 2008, 01:50 UTC
Message-ID
<7v3aokjpxv.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<alpine.DEB.1.00.0805150204440.30431@racer>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 5 quoted lines
>> That's exactly the point.  The option reads "ignore submodules", not 
>> "special option for use only by stash and rebase".
>
> But it also does not read "ignore submodules and those blobs/trees that 
> happen to replace (or be replaced by) submodules".

I think "ignore submodules" option, if exists, would mean "ignore changes that involve submodules", and I think everybody would agree with that.

Because we are talking about an option to "diff", changes involve two sides (preimage and postimage). Logically, you can define the class of changes that involve submodules in two ways:

 * both sides of the change must be a submodule; otherwise the change does
   not involve a submodule.
 * either side of the change is a submodule; such a change involve a
   submodule.

I am saying that the latter makes much more sense (worse yet, what you did for creation and deletion is inconsistent --- they are void vs submodule and you treat them as "change that involve submodule").

Didn't you make the option introduction to read "sometimes you are not interested in submodules..." or something?

Previous: Johannes SchindelinNext: Johannes Schindelin
Message 9 of 12 in “sane rebase/stash support with submodules”
  1. 0/3 sane rebase/stash support with submodulesJohannes Schindelin, May 14, 2008
  2. 1/3 diff options: Introduce --ignore-submodulesJohannes Schindelin, May 14, 2008
  3. Junio C HamanoMay 14, 2008
  4. Johannes SchindelinMay 14, 2008
  5. Junio C HamanoMay 14, 2008
  6. Johannes SchindelinMay 14, 2008
  7. Junio C HamanoMay 14, 2008
  8. Johannes SchindelinMay 15, 2008
  9. Junio C HamanoMay 15, 2008
  10. Johannes SchindelinMay 15, 2008
  11. 2/3 Teach update-index about --ignore-submodulesJohannes Schindelin, May 14, 2008
  12. 3/3 Ignore dirty submodule states during rebase and stashJohannes Schindelin, May 14, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.