git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/Test] Build in merge is broken

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 13, 2008, 19:11 UTC
Message-ID
<7v3amdtx8x.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20080713184300.GF10347@genesis.frugalware.org>
Miklos Vajna <vmiklos@frugalware.org> writes:
Show 8 quoted lines
> On Sun, Jul 13, 2008 at 07:46:59PM +0200, Miklos Vajna <vmiklos@frugalware.org> wrote:
>> So far what I see is that the input for the reduce_heads() function is
>> (c1, c0, c2, c0, c1). The expected output would be (c1, c2), but the
>> actual output is c2. So I suspect the bug is not in builtin-merge.c
>> itself but in reduce_heads().
>
> This fixes the problem for me. Junio, does the fix looks correct to you
> as well?

You are correct, the "item"s are the highlander (i.e. "there can be only one") objects but commit-list elements that hold pointers to them are not, so we need to dereference and compare.

Thanks.
Previous: Miklos VajnaNext: Sverre Hvammen Johansen
Message 5 of 7 in “Build in merge is broken”
  1. Build in merge is brokenSverre Hvammen Johansen, Jul 13, 2008
  2. Miklos VajnaJul 13, 2008
  3. Miklos VajnaJul 13, 2008
  4. Miklos VajnaJul 13, 2008
  5. Junio C HamanoJul 13, 2008
  6. Sverre Hvammen JohansenJul 14, 2008
  7. Junio C HamanoJul 14, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.