Re: What's cooking in git/spearce.git (Oct 2008, #02; Sun, 12)

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 13, 2008, 02:05 UTC
Message-ID: <7v3aj1fdw2.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20081012212543.GG4856@spearce.org>

"Shawn O. Pearce" <spearce@spearce.org> writes:

Show 5 quoted lines

> * pb/rename-rowin32 (Fri Oct 3 12:20:43 2008 +0200) 1 commit
>  - Do not rename read-only files during a push
>
> Supposedly fixes pack file renames on Windows, but it makes the
> test suite fail on Linux.  I haven't debugged why yet.

I am kind of surprised that it actually passes the test on Windows, which implies that these cats shown in the patch to fix this breakage below do not honor ro-ness of the file, which in turn makes me doubt if making the resulting packfiles read-only has any effect on that platform whatsoever..

 t/t5300-pack-object.sh |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git i/t/t5300-pack-object.sh w/t/t5300-pack-object.sh
index b335c6b..544f59e 100755
--- i/t/t5300-pack-object.sh
+++ w/t/t5300-pack-object.sh
@@ -248,6 +248,7 @@ test_expect_success \
      git index-pack test-3.pack &&
      cmp test-3.idx test-1-${packname_1}.idx &&
 
+     rm -f test-3.pack &&
      cat test-2-${packname_2}.pack >test-3.pack &&
      git index-pack -o tmp.idx test-2-${packname_2}.pack &&
      cmp tmp.idx test-2-${packname_2}.idx &&
@@ -255,6 +256,7 @@ test_expect_success \
      git index-pack test-3.pack &&
      cmp test-3.idx test-2-${packname_2}.idx &&
 
+     rm -f test-3.pack &&
      cat test-3-${packname_3}.pack >test-3.pack &&
      git index-pack -o tmp.idx test-3-${packname_3}.pack &&
      cmp tmp.idx test-3-${packname_3}.idx &&