Re: [PATCH 2/2] mergetool: fix running mergetool in sub-directories
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 7, 2009, 21:48 UTC
- Message-ID
- <7v3aepuddk.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <49877F68.30509@hashpling.org>
Charles Bailey <charles@hashpling.org> writes:
Show 12 quoted lines
> Junio C Hamano wrote: >> >> I wonder if it would be cleaner to keep $prefix and instead cd_to_toplevel >> at the beginning. >> ... > Possibly, and I certainly wouldn't object if mergetool moved to the > latter mode of operation in the medium term. > > In general, though, mergetool is pretty happy running from the users > directory and there may be cases in which users expect the merge tool to > be running from the directory that they started in (saving extra files > during the merge process?).
A very sensible consideration that I agree with. I am happy that you were the one who volunteered to take this script over.