Re: [PATCH] git stash: Give friendlier errors when there is nothing to apply

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 14, 2009, 19:52 UTC
Message-ID: <7v3a7ujhqb.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4a81787d.0e0f660a.5238.4c8b@mx.google.com>

Ori Avtalion <ori@avtalion.name> writes:

Show 16 quoted lines

> The change makes sure a stash (given or default) exists before
> checking if the working tree is dirty.
>
> If the default stash is requested, the old message was scary and
> included a 'fatal' error from rev-parse:
>      fatal: Needed a single revision
>      : no valid stashed state found
>
> It is replaced with a friendlier 'Nothing to apply' error, similar to
> 'git stash branch'.
>
> If a specific stash is specified, the 'Needed a single revision' errors
> from rev-parse are suppressed.
>
> Signed-off-by: Ori Avtalion <ori@avtalion.name>
> Acked-by: Thomas Rast <trast@student.ethz.ch>

I do not see anything that might break existing usage of the command. Comments?

A tangent; we might want an analogue to "shortlog -s -n" but based on "blame".