git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix MSVC build on cygwin

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 9, 2009, 06:48 UTC
Message-ID
<7v3a5t6p1f.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4ACE0388.6070706@ramsay1.demon.co.uk>
Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
Show 13 quoted lines
> In the MSVC section of the Makefile, BASIC_CFLAGS is set to a
> value which contains the string "-DWIN32-D_CONSOLE". This results
> in a (single) malformed -Define being passed to the compiler.
> At least on my cygwin installation, the msvc compiler seems to
> ignore this parameter, without issuing an error or warning, and
> results in the WIN32 and _CONSOLE macros being undefined. This
> breaks the build.
>
> In order to fix the build, we simply insert a space between the
> two -Define parameters, "-DWIN32" and "-D_CONSOLE", as originally
> intended.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>

Thanks; that's quite a detailed description to explain why -DFOO-DBAR is bad when -DFOO -DBAR was wanted ;-)

Previous: Sverre RabbelierNext: Ramsay Jones
Message 4 of 5 in “Fix MSVC build on cygwin”
  1. Fix MSVC build on cygwinRamsay Jones, Oct 8, 2009
  2. Johannes SchindelinOct 8, 2009
  3. Sverre RabbelierOct 8, 2009
  4. Junio C HamanoOct 9, 2009
  5. Ramsay JonesOct 9, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.