Re: [PATCH] Fix indentation problem in git-ls-files(1)

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 4, 2010, 23:37 UTC
Message-ID: <7v3a0fr740.fsf@alter.siamese.dyndns.org>
In-Reply-To: <m2tyswb1jp.fsf@igel.home>

Andreas Schwab <schwab@linux-m68k.org> writes:

Show 6 quoted lines

> The nested list in the description of the -t option wasn't properly
> indented.  Additionally, make it a horizontal labeled list since the
> labels are all short.
>
> Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
> ---

Thanks.

Show 26 quoted lines

>  Documentation/git-ls-files.txt |   15 ++++++++-------
>  1 files changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/git-ls-files.txt b/Documentation/git-ls-files.txt
> index 3521637..c0dc3ec 100644
> --- a/Documentation/git-ls-files.txt
> +++ b/Documentation/git-ls-files.txt
> @@ -108,13 +108,14 @@ OPTIONS
>  -t::
>  	Identify the file status with the following tags (followed by
>  	a space) at the start of each line:
> -	H::	cached
> -	S::	skip-worktree
> -	M::	unmerged
> -	R::	removed/deleted
> -	C::	modified/changed
> -	K::	to be killed
> -	?::	other
> +[horizontal]
> +	H:::	cached
> +	S:::	skip-worktree
> +	M:::	unmerged
> +	R:::	removed/deleted
> +	C:::	modified/changed
> +	K:::	to be killed
> +	?:::	other

Both [horizontal] and three colons are something we never have used in the existing documentation set. How confident are you that various versions of deployed AsciiDoc people would use all support this?

I am not _complaining_; I am just being cautious to see if I have to look into the issue myself (if your answer is "not at all") or not (otherwise).

Cf. http://thread.gmane.org/gmane.comp.version-control.git/139014/focus=139339