Re: [PATCH] tests: cleanup binary images usage

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 19, 2011, 19:03 UTC
Message-ID: <7v39i29jpe.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1311096107.8532.39.camel@vivanov>

Vitaliy Ivanov <vitalivanov@gmail.com> writes:

Show 5 quoted lines

> ---
>>From bff3916939fcd226278a2e983ddc77bb711296e7 Mon Sep 17 00:00:00 2001
> From: Vitaliy Ivanov <vitalivanov@gmail.com>
> Date: Tue, 19 Jul 2011 20:07:08 +0300
> Subject: [PATCH] tests: cleanup binary images usage

Thanks.

Drop the above five lines and replace them with a single "-- >8 --" line. The lone "---" line is especially harmful as it tells our tools to stop reading anything below when finding your commit log message.

> Images are being shared between tests and this is OK.
> By this patch I name images independently of tests plus
> remove unneeded images.

The point of these test vector files are that they are binary and it is secondary that they happen to be images.

Perhaps like this.

  Hi, list,

  Extra and redundant explanation that you could have just let your
  proposed commit log message speak for itself comes here, if you really
  need one.

  -- >8 --
  tests: cleanup binary test vector files

  The test4012.png test vector file that was originally used for t4012 to
  check operations on binary files was later reused in other tests, making
  it no longer consistent to name it after a specific test. Rename it to more
  generic "test-binary-1.png".

  While at it, rename test9200b to "test-binary-2.png" (even though it is
  only used by t9200).

  Signed-off-by: Vitaliy Ivanov <vitalivanov@gmail.com>
  ---
  <<diffstat and patch here>>

Show 18 quoted lines

> Signed-off-by: Vitaliy Ivanov <vitalivanov@gmail.com>
> ---
>  t/t3307-notes-man.sh           |    6 +++---
>  t/t4012-diff-binary.sh         |    2 +-
>  t/t6023-merge-file.sh          |    2 +-
>  t/t6027-merge-binary.sh        |    2 +-
>  t/t9200-git-cvsexportcommit.sh |   14 +++++++-------
>  t/test-image1.png              |  Bin 0 -> 5660 bytes
>  t/test-image2.png              |  Bin 0 -> 275 bytes
>  t/test4012.png                 |  Bin 5660 -> 0 bytes
>  t/test9200a.png                |  Bin 5660 -> 0 bytes
>  t/test9200b.png                |  Bin 275 -> 0 bytes
>  10 files changed, 13 insertions(+), 13 deletions(-)
>  create mode 100644 t/test-image1.png
>  create mode 100644 t/test-image2.png
>  delete mode 100644 t/test4012.png
>  delete mode 100644 t/test9200a.png
>  delete mode 100644 t/test9200b.png

Also have you considered using "format-patch -M" to send this patch?