Re: [PATCH] remote-curl: don't pass back fake refs

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 19, 2011, 21:28 UTC
Message-ID: <7v39cgmety.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20111219211203.GA18396@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 12 quoted lines

> On Mon, Dec 19, 2011 at 11:28:14AM -0800, Junio C Hamano wrote:
>
>> Jeff King <peff@peff.net> writes:
>> 
>> > Perhaps we should squash in the test below, which demonstrates the
>> > breakage. I also wonder if this is maint-worthy.
>> 
>> Thanks for a thorough analysis. I agree that this should go to maint even
>> more so, as it fixes a case to push to a non-empty repository.
>
> Do you want to squash in those tests, or should I re-send with a commit
> message more fully explaining the situation?

I was lazy and added these three lines at the end:

    This also fixes pushing with --mirror to a smart-http remote that uses
    alternates. The fake ".have" refs the server gives to avoid unnecessary
    network transfer has a similar bad interactions with the machinery.

but it may warrant a more thorough write-up there.