Re: [PATCH] Explicitly set X to avoid potential build breakage

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 5, 2012, 22:14 UTC
Message-ID: <7v39apexmk.fsf@alter.siamese.dyndns.org>
In-Reply-To: <9854382.GTBzd7D6AT@telegraph>

Michael <kensington@astralcloak.net> writes:

Show 5 quoted lines

> $X is appended to binary names for Windows builds (ie. git.exe).
> Pollution from the environment can inadvertently trigger this behaviour,
> resulting in 'git' turning into 'gitwhatever' without warning.
>
> Signed-off-by: Michael <kensington@astralcloak.net>

Unless there is a compelling reason not to, could we have your name here, not just half a name, please?

It is not particularly a good reason to say "I go by 'Michael' among my friends". The output from "git shortlog -s --author=Michael" shows more than 20 Michaels already, and it would be nice for us if we can easily differenciate you among this group of people you are now joining with this patch.

Show 15 quoted lines

> ---
>  Makefile |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index c457c34..380d96f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -388,6 +388,9 @@ SCRIPT_SH =
>  SCRIPT_LIB =
>  TEST_PROGRAMS_NEED_X =
>  
> +# Binary suffix used for Windows builds
> +X =
> +

The patch looks good to me, although it might make sense to move it down before this line

	PROGRAMS += $(patsubst %.o,git-%$X,$(PROGRAM_OBJS))

where it matters most as the documentation of what $X is being used for.