git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Documentation: indent-with-non-tab uses tabwidth setting, not just 8

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 17, 2012, 05:16 UTC
Message-ID
<7v392hxm94.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1347815548-19305-1-git-send-email-wjl@icecavern.net>
"Wesley J. Landaker" <wjl@icecavern.net> writes:
Show 23 quoted lines
> From: "Wesley J. Landaker" <wjl@icecavern.net>
>
> Update the documentation of the core.whitespace option
> "indent-with-non-tab" to correctly reflect that it uses the currently
> set tab width, set by the "tabwidth" option, rather than a fixed number.
>
> Signed-off-by: Wesley J. Landaker <wjl@icecavern.net>
> ---
>  Documentation/config.txt |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index 6416cae..113a196 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -559,8 +559,8 @@ core.whitespace::
>  * `space-before-tab` treats a space character that appears immediately
>    before a tab character in the initial indent part of the line as an
>    error (enabled by default).
> -* `indent-with-non-tab` treats a line that is indented with 8 or more
> -  space characters as an error (not enabled by default).
> +* `indent-with-non-tab` treats a line that is indented with `tabwidth` space
> +  characters or more as an error (not enabled by default).
I would rather see this part left untouched.

Your new text will force people who are not interested in using non-standard tab width to read through the bulletted list, only to find "The default tab width is 8". I think that is a regression in the documentation for more common readers.

When somebody wants to use `indent-with-non-tab` and gets offended by the seemingly hardcoded "8" in the description, the reader has incentive to find out if there is a way to change that 8, and will find `tabwidth=<n>` in the same bulletted list described, with the effect it has on both `indent-with-non-tab` and `tab-in-indent`.

I think that should be sufficient for people who do use non-standard tab width using tabwidth=<n>.

Previous: Wesley J. LandakerNext: Wesley J. Landaker
Message 2 of 7 in “Documentation: indent-with-non-tab uses tabwidth setting, not just 8”
  1. Documentation: indent-with-non-tab uses tabwidth setting, not just 8Wesley J. Landaker, Sep 16, 2012
  2. Junio C HamanoSep 17, 2012
  3. Wesley J. LandakerSep 17, 2012
  4. Junio C HamanoSep 17, 2012
  5. Wesley J. LandakerSep 17, 2012
  6. Documentation: indent-with-non-tab uses "equivalent tabs" not 8Wesley J. Landaker, Sep 17, 2012
  7. Junio C HamanoSep 17, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.