Re: [PATCH] Add Auto-Submitted header to post-receive-email
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 21, 2012, 17:06 UTC
- Message-ID
- <7v392b8fv3.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <67C048AA-0DA7-4397-A257-E0BE66089A5D@salk.edu>
Chris Hiestand <chiestand@salk.edu> writes:
Show 23 quoted lines
> My email in April went unanswered so I'm resending it. An Auto-Submitted header > would be an improvement to the standard [git] post receive email. > > Thanks, > Chris > > > Begin forwarded message: > >> From: Chris Hiestand <chiestand@salk.edu> >> Subject: [PATCH] Add Auto-Submitted header to post-receive-email >> Date: April 14, 2012 6:15:10 PM PDT >> To: git@vger.kernel.org, gitster@pobox.com >> >> Hi, >> >> I think the Auto-Submitted header is a useful hook mail header to include by default. >> >> This conforms to RFC3834 and is useful in preventing e.g. vacation auto-responders >> from replying by default. >> >> Perhaps you have already considered this and decided not to include it, but I found >> no record of such a conversation on this list.
I think the lack of response is generally lack of interest, and the primary reason for that was because the To/Cc list did not contain anybody who touched this particular file in the past (and no, I am not among them; as contrib/README says, I am often the wrong person to ask if a patch to contrib/ material makes sense).
>> From 358fc3ae1ebfd7723d54e4033d3e9a9a0322c873 Mon Sep 17 00:00:00 2001 >> From: Chris Hiestand <chiestand@salk.edu> >> Date: Sat, 14 Apr 2012 17:58:39 -0700 >> Subject: [PATCH] Add Auto-Submitted header to post-receive-email
These four lines should not be in the body of the e-mail message (see Documentation/SubmittingPatches).
Show 6 quoted lines
>> Adds Auto-Submitted: auto-generated to post-receive-email header >> This conforms to RFC3834 and is useful in preventing eg >> vacation auto-responders from replying by default >> --- >> contrib/hooks/post-receive-email | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-)
Even for contrib/ material, please always sign-off your patch (see Documentation/SubmittingPatches).
Show 13 quoted lines
>> >> diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email >> index 01af9df..282507c 100755 >> --- a/contrib/hooks/post-receive-email >> +++ b/contrib/hooks/post-receive-email >> @@ -237,6 +237,7 @@ generate_email_header() >> X-Git-Reftype: $refname_type >> X-Git-Oldrev: $oldrev >> X-Git-Newrev: $newrev >> + Auto-Submitted: auto-generated >> >> This is an automated email from the git hooks/post-receive script. It was >> generated because a ref change was pushed to the repository containing
I think the choice of "auto-generated" is a sensible one, as responding to a 'push' is like triggered by 'cron'.
I'd however appreciate comments from people who either worked on this code or list regulars who actually use this code in the production.
Thanks.