Re: [PATCH] silence git gc --auto --quiet output

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 24, 2012, 22:42 UTC
Message-ID: <7v3927xcu1.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120924024024.GA12700@tin.tmux.org>

Tobias Ulmer <tobiasu@tmux.org> writes:

Show 23 quoted lines

> When --quiet is requested, gc --auto should not display messages unless
> there is an error.
>
> Signed-off-by: Tobias Ulmer <tobiasu@tmux.org>
> ---
>  builtin/gc.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/builtin/gc.c b/builtin/gc.c
> index 6d46608..6be6c8d 100644
> --- a/builtin/gc.c
> +++ b/builtin/gc.c
> @@ -217,9 +217,7 @@ int cmd_gc(int argc, const char **argv, const char *prefix)
>  		 */
>  		if (!need_to_gc())
>  			return 0;
> -		if (quiet)
> -			fprintf(stderr, _("Auto packing the repository for optimum performance.\n"));
> -		else
> +		if (!quiet)
>  			fprintf(stderr,
>  					_("Auto packing the repository for optimum performance. You may also\n"
>  					"run \"git gc\" manually. See "

This patch will break t5400; the test needs to be updated in the same patch to check auto-gc kicks in when it should in some other way. The test currently _relies_ on this message to see the gc is triggered.