Re: [PATCH v2 05/14] remote: remove dead code in read_branches_file()
Ramkumar Ramachandra <artagnon@gmail.com> writes:
Show 11 quoted lines
> - /*
> - * With "slash", e.g. "git fetch jgarzik/netdev-2.6" when
> - * reading from $GIT_DIR/branches/jgarzik fetches "HEAD" from
> - * the partial URL obtained from the branches file plus
> - * "/netdev-2.6" and does not store it in any tracking ref.
> - * #branch specifier in the file is ignored.
> - *
> - * Otherwise, the branches file would have URL and optionally
> - * #branch specified. The "master" (or specified) branch is
> - * fetched and stored in the local branch of the same name.
> - */
Removal of the second paratraph is wrong, isn't it?
Show 17 quoted lines
> frag = strchr(p, '#');
> if (frag) {
> *(frag++) = '\0';
> strbuf_addf(&branch, "refs/heads/%s", frag);
> } else
> strbuf_addstr(&branch, "refs/heads/master");
> - if (!slash) {
> - strbuf_addf(&branch, ":refs/heads/%s", remote->name);
> - } else {
> - strbuf_reset(&branch);
> - strbuf_addstr(&branch, "HEAD:");
> - }
> +
> + strbuf_addf(&branch, ":refs/heads/%s", remote->name);
> add_url_alias(remote, p);
> add_fetch_refspec(remote, strbuf_detach(&branch, NULL));
> /*Junio C Hamano <gitster@pobox.com>