git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Fix for git-rev-list --merge-order B ^A (A,B share common base)

From
Junio C Hamano <junkio@cox.net>
Date
Jun 30, 2005, 00:11 UTC
Message-ID
<7v1x6k1z6c.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20050629234533.28709.qmail@blackcubes.dyndns.org>
>>>>> "JS" == Jon Seymour <jon.seymour@gmail.com> writes:
I am puzzled about this part.

JS> The unit test changes in this patch remove use of the --show-breaks JS> flags from certain unit tests. The changed --merge-order behaviour JS> changed the annotation that --show-breaks prints for certain test cases. JS> The new behaviour is reasonable and irrelevant to the intent of the tests JS> so that tests have been changed to eliminate the spurious behaviour.

If the behaviour of --show-breaks subtly changes, and if that changed behaviour is something still acceptable, why not update the test to show the new expected results since you are updating the test anyway?

Showing that "subtle" change in the diff may draw people's attention and would help you to verify that the behaviour change is not something that would be unacceptable to them.

Also if you are changing t6001, could you also merge Mark Allen's BSD portability fix while you are at it?

    Message-ID: <20050628014337.18986.qmail@web41205.mail.yahoo.com>
Previous: Jon SeymourNext: Jon Seymour
Message 2 of 4 in “Fix for git-rev-list --merge-order B ^A (A,B share common base)”
  1. 2/2 Fix for git-rev-list --merge-order B ^A (A,B share common base)Jon Seymour, Jun 29, 2005
  2. Junio C HamanoJun 30, 2005
  3. Jon SeymourJun 30, 2005
  4. Jon SeymourJun 30, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.