git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: omitted test scripts?

From
Junio C Hamano <junkio@cox.net>
Date
Sep 19, 2005, 16:19 UTC
Message-ID
<7v1x3lrpxi.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<432EDE3F.7070407@citi.umich.edu>
Chuck Lever <cel@citi.umich.edu> writes:
> i noticed while testing the new cache API that there are no tests under 
> t/ for git-merge-index.

In the past, when I did any major butchering of existing code or made nontrivial additions, I wrote test scripts to cover what should happen (and what to be preserved) first to make sure the changes or additions would not introduce regression. I think we have been reasonably successful (Daniel could fill us in with experiences with read-tree tests).

I have been expecting people to follow suit, without explicitly asking them to do, so when I took over the project. Further I got sloppy when accepting any sizable patches. Sorry about that.

> there is also no test script that covers the prune_cache() function in 
> ls-files.c.

That's one of the item on the TODO list and patches to extend test coverage are always welcomed.

Previous: Chuck LeverNext: Daniel Barkalow
Message 12 of 14 in “git-merge-cache / StGIT - gitmergeonefile.py: merging one tree into another rather than two trees into merge base”
  1. BlaisorbladeSep 10, 2005
  2. Catalin MarinasSep 11, 2005
  3. Chuck LeverSep 12, 2005
  4. BlaisorbladeSep 14, 2005
  5. BlaisorbladeSep 14, 2005
  6. BlaisorbladeSep 14, 2005
  7. Catalin MarinasSep 15, 2005
  8. BlaisorbladeSep 16, 2005
  9. Junio C HamanoSep 16, 2005
  10. Catalin MarinasSep 17, 2005
  11. omitted test scripts?Chuck Lever, Sep 19, 2005
  12. Junio C HamanoSep 19, 2005
  13. Daniel BarkalowSep 19, 2005
  14. Matthias UrlichsSep 19, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.