Re: [PATCH] Git.xs: older perl do not know const char *
- From
Junio C Hamano <junkio@cox.net>
- Date
- Jul 2, 2006, 22:39 UTC
- Message-ID
- <7v1wt33a3l.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <20060702215249.GK29115@pasky.or.cz>
Petr Baudis <pasky@suse.cz> writes:
Show 11 quoted lines
> Dear diary, on Sun, Jul 02, 2006 at 11:53:03AM CEST, I got a letter > where Johannes Schindelin <Johannes.Schindelin@gmx.de> said that... >> Both of these casts _should_ be safe, since you do not want to muck around >> with the version or the path anyway. >> >> Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de> > > Acked-by: Petr Baudis <pasky@suse.cz> > > It isn't all that great but it seems everything xs does with this is to > feed it to sv_setpv() which AFAIK copies it around.
Thanks. Already applied but not pushed out yet (I am working on tracking down unrelated breakage in tests).