Re: [PATCH] support cover letter before commit log, using "+++"

From: Junio C Hamano <junkio@cox.net>
Date: Jul 24, 2006, 06:54 UTC
Message-ID: <7v1wsbfq75.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060723214524.GC20068@admingilde.org>

Martin Waitz <tali@admingilde.org> writes:

Show 8 quoted lines

> We already have a "---" separator to end the commit log.
> But writing the cover letter after this separator looks strange.
> Now it is possible to put the cover letter and comments both before
> or after the commit log, as the author sees fit.
>
> Just put the commit log between lines starting with "+++" and "---".
>
> Signed-off-by: Martin Waitz <tali@admingilde.org>

I do not have problem with the implementation itself, but

* I always had an impression that cover letters are tolerated
  not encouraged.  In other words, as a good practice it would
  be nice if necessary information is described in the commit
  log messages themselves.  Do we want to start encouraging the
  cover letter with this patch?

* Has anybody ever used that "+++" as an auxiliary separator?
  In other words, is it an established convention?  If not,
  would it be a good convention that we would want to establish
  here?