Re: [PATCH] gitweb: Use File::Find::find in git_get_projects_list

From: Junio C Hamano <junkio@cox.net>
Date: Sep 14, 2006, 09:23 UTC
Message-ID: <7v1wqe6buv.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200609140959.04061.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

Show 5 quoted lines

> Not true. Link to directory is both -d $_ and -l $_, so
>
> 	return unless (-d $_ || (-l $_ && -d readlink($_)));
>
> is not needed.

I think you mis-read what I said. I first wondered why you did not say "return unless -d _" and wrote (seemingly more inefficient) "return unless -d $_". The comment is to clarify why '$' is needed.

In other words, after this setup:

        $ rm -fr d dl
        $ mkdir d
        $ ln -s d dl

you do not see an output from this:

        $ perl -e 'lstat "dl"; print "is-dir\n" if -d _;'

but you do from this:

        $ perl -e 'lstat "dl"; print "is-dir\n" if -d "dl";'