Re: [PATCH 0/3] gitweb: Simplify some gitweb URLs generation

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 1, 2007, 22:47 UTC
Message-ID: <7v1wb98twi.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1193918789-16421-1-git-send-email-jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

Show 12 quoted lines

> This series of patches simplifies some gitweb URLs generation by
> providing -replay option to href() subroutine, and then using this
> feature in gitweb code.
>
> Shortlog:
>  gitweb: Easier adding/changing parameters to current URL
>  gitweb: Use href(-replay=>1, page=>...) to generate pagination links
>  gitweb: Use href(-replay=>1, action=>...) to generate alternate views
>
> Diffstat:
>  gitweb/gitweb.perl |   82 ++++++++++++++++++++++-----------------------------
>  1 files changed, 35 insertions(+), 47 deletions(-)

If this "-replay" is used carelessly, it could add parameters that were passed to the page that the original code stripped away from passing on purpose. Have you checked if the conversion done with 2/3 and 3/3 are correct (I haven't)?