git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git fsck segmentation fault

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 11, 2008, 06:42 UTC
Message-ID
<7v1vwfw6u7.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20081211062753.GA17683@auto.tuwien.ac.at>
mkoegler@auto.tuwien.ac.at (Martin Koegler) writes:
> fsck_walk has been designed to call a function on all directly
> connected objected. There are callers, which expected this behaviour
> (eg. index-pack, mark_used in fsck).

Yes, that is where my "initially expected" comes from. I was not complaining or suggesting the behaviour to change.

I was fooled by the word *walk* in the name, which implies an implementation of walking connectivity fully, with or without an ability for the callback to tell the machinery when to or not to dig deeper. It wouldn't have been confusing if it were named "fsck_step()", which is what the function is about: performing a single step of digging deeper.

Previous: Martin Koegler
Message 12 of 12 in “git fsck segmentation fault”
  1. Simon HausmannNov 27, 2008
  2. Nicolas PitreNov 27, 2008
  3. Simon HausmannNov 27, 2008
  4. Simon HausmannNov 27, 2008
  5. Nicolas PitreNov 27, 2008
  6. Simon HausmannNov 28, 2008
  7. Nicolas PitreDec 9, 2008
  8. Martin KoeglerDec 9, 2008
  9. Martin KoeglerDec 10, 2008
  10. Junio C HamanoDec 11, 2008
  11. Martin KoeglerDec 11, 2008
  12. Junio C HamanoDec 11, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.