Re: [PATCH] send-email: Add config option for sender address

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 13, 2009, 07:45 UTC
Message-ID: <7v1vrxhu8x.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20090410093432.6117@nanako3.lavabit.com>

Nanako Shiraishi <nanako3@lavabit.com> writes:

Show 21 quoted lines

> Quoting Trent Piepho:
>
>> The sender address, as specified with the '--from' command line option,
>> couldn't be set in the config file.  So add a new config option,
>> 'sendemail.from', which sets it.  One can use 'sendemail.<identity>.from'
>> as well of course, which is likely the more useful case.
>> 
>> The sender address would default to GIT_AUTHOR_IDENT, which is usually the
>> right thing, but this doesn't allow switching based on the identity
>> selected.  It's possible to switch the SMTP server and envelope sender by
>> using the '--identity' option, in which case one probably wants to use a
>> different from address as well, but this had to be manually specified.
>> 
>> The docs are also fixed up somewhat.  If '--from' is specified (or the new
>> sendemail.from option is used) then the user isn't prompted.  The default
>> with no '--from' option (or sendemail.from option) is GIT_AUTHOR_IDENT
>> first then GIT_COMMITTER_IDENT, not just GIT_COMMITTER_IDENT.
>> 
>> Signed-off-by: Trent Piepho <xyzzy@speakeasy.org>
>
> Junio, may I ask what happened to this patch?

If I recall correctly, it didn't look too invasive and I found it Ok, but I didn't see any comments on it, so it was dropped on the floor.

Perhaps Trent cares to resend?