Re: Minor bug in bash completion

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 30, 2009, 18:00 UTC
Message-ID: <7v1vic2vh6.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20091230112222.GA493@neumann>

SZEDER Gábor <szeder@ira.uka.de> writes:

Show 11 quoted lines

> On Tue, Dec 29, 2009 at 03:36:58PM +0100, Sylvain RABOT wrote:
>> I found a bug in the git bash completion.
>> It occurs when I press tab to complete branch name when I want to pull  
>> from the origin.
>> Instead of completing the branch name it prompts me directly for my  
>> password on the origin remote.
>
> I don't think it's a bug.  The completion script should offer the
> currently available refs in the remote repository after a 'git pull
> <remote> <TAB>'.  In order to do that it contacts the remote
> repository for the list of refs available there.

It is definitely a non-bug since the user _asked_ to complete and the information necessary to do the job the user _asked_ to do is only accessible over the network connection.

I however do think this is an annoyance when it happens to you by accident. I wonder if it is worth to have a way for users to tell completion to skip the ls-remote invocation (hence not getting branches completed) depending on the type of remote.