Re: [PATCH] fetch-pack: make the ssh connection quiet

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 27, 2010, 22:35 UTC
Message-ID: <7v1v7bclhe.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1288189628-4883-1-git-send-email-jstepien@users.sourceforge.net>

Jan Stępień  <jstepien@users.sourceforge.net> writes:

> The --quiet option passed to fetch-pack did not affect the ssh child
> process. When an ssh server sent a motd it was displayed because the ssh
> client wasn't launched with the -q option.

This is curious for a couple of reasons:

1. "-q" option to "ssh" is not meant to supress "motd"; it is about
   warning and diagnostics.  From man ssh(1):

     -q Quiet mode.  Causes most warning and diagnostic messages to be
        suppressed.  Only fatal errors are displayed.  If a second -q is
        given then even fatal errors are suppressed, except for those
        produced due solely to bad argu‐ ments.

2. "PrintMotd" defaults to "yes" but it is to specify whether the daemon
   should print /etc/motd when a user logs in interactively.  I didn't
   think fetch-pack logged in interactively, so why should this matter?