git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC 1/3] Alternates API: Untangle the interface

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 30, 2011, 22:28 UTC
Message-ID
<7v1v1omeec.fsf@alter.siamese.dyndns.org>
In-Reply-To
<5ed7886ec5e12c8e3a5f45d19625a4f5d2cdd38a.1301521243.git.mfwitten@gmail.com>
Michael Witten <mfwitten@gmail.com> writes:
Show 11 quoted lines
> diff --git a/transport.c b/transport.c
> index a02f79a..c61723f 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -1190,14 +1190,13 @@ literal_copy:
>  	return xstrdup(url);
>  }
>  
> -int refs_from_alternate_cb(struct alternate_object_database *e, void *cb)
> +int refs_from_alternate_cb(struct alternate_object_database *e, alternate_ref_fn ref_fn)
>  {

Adding an extra "fn" is Ok, but I'd rather not to see removal of generic callback data pointer if the _only_ reason you are doing so is "currently nobody uses it".

Besides, I see "a function pointer and a data pointer cannot be held in a single variable" as an academic mental mastu^wexercise that is useless in real life. Are there real platforms that matter where (void *) cannot hold a pointer to a function?

Previous: Michael WittenNext: Michael Witten
Message 7 of 12 in “[RFC 1/2] Portability: Convert strictly between function pointers”
  1. Michael WittenMar 29, 2011
  2. 2/2 Future Proofing: Pass around pointers to either functions or dataMichael Witten, Mar 29, 2011
  3. Erik Faye-LundMar 30, 2011
  4. Michael WittenMar 30, 2011
  5. Junio C HamanoMar 30, 2011
  6. 1/3 Alternates API: Untangle the interfaceMichael Witten, Mar 30, 2011
  7. Junio C HamanoMar 30, 2011
  8. 2/3 Alternates API: Improve namingMichael Witten, Mar 30, 2011
  9. Junio C HamanoMar 30, 2011
  10. 3/3 Alternates API: Remove unused parameterMichael Witten, Mar 30, 2011
  11. 0/3 Alternates APIMichael Witten, Mar 30, 2011
  12. Junio C HamanoMar 30, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.