git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] notes remove: allow removing more than one

From
Junio C Hamano <gitster@pobox.com>
Date
May 19, 2011, 06:50 UTC
Message-ID
<7v1uzv9oab.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4DD4BC0D.2000805@drmicha.warpmail.net>
Michael J Gruber <git@drmicha.warpmail.net> writes:
[jc: cull the part you did not comment on, thanks]
Show 14 quoted lines
>> +test_expect_success 'removing more than one' '
>> +	before=$(git rev-parse --verify refs/notes/commits) &&
>> +	test_when_finished "git update-ref refs/notes/commits $before" &&
>> +	git notes remove HEAD^^ HEAD^^^ &&
>> +	git diff --name-only refs/notes/commits^ refs/notes/commits >actual &&
>> +	test 2 = $(wc -l <actual) &&
>> +	git ls-tree -r --name-only refs/notes/commits >actual &&
>> +	>empty &&
>> +	test_cmp empty actual
>> +'
>
> You're not really testing that this removes the correct notes. Actually,
> you're not even testing that this removes only 2 notes when there are
> more than 2, are you?

In the test vector, there are only two notes, and I am testing removal of multiple. What do you want me to do? Test removing one and make sure the other one survives ;-)? 

Patches on top of it is very welcome, but I wouldn't bother.
Previous: Michael J GruberNext: Michael J Gruber
Message 4 of 17 in “"git notes remove" updates”
  1. 0/3 "git notes remove" updatesJunio C Hamano, May 19, 2011
  2. 1/3 notes remove: allow removing more than oneJunio C Hamano, May 19, 2011
  3. Michael J GruberMay 19, 2011
  4. Junio C HamanoMay 19, 2011
  5. Michael J GruberMay 19, 2011
  6. Junio C HamanoMay 19, 2011
  7. 1/2 fixup! notes remove: --ignore-missingMichael J Gruber, May 19, 2011
  8. 2/2 fixup! notes remove: --stdin reads from the standard inputMichael J Gruber, May 19, 2011
  9. 2/3 notes remove: --missing-okJunio C Hamano, May 19, 2011
  10. Junio C HamanoMay 19, 2011
  11. 3/3 notes remove: --stdin reads from the standard inputJunio C Hamano, May 19, 2011
  12. Michael J GruberMay 19, 2011
  13. Jeff KingMay 19, 2011
  14. Junio C HamanoMay 19, 2011
  15. Jeff KingMay 19, 2011
  16. 4/3 show: --ignore-missingJunio C Hamano, May 19, 2011
  17. Johan HerlandMay 19, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.