git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/4] streaming filter: ident filter and filter cascading

From
Junio C Hamano <gitster@pobox.com>
Date
May 22, 2011, 01:00 UTC
Message-ID
<7v1uzrzh04.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4DD837EE.3010608@lsrfire.ath.cx>
René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
Show 11 quoted lines
> Am 21.05.2011 23:05, schrieb René Scharfe:
>>> +		if (ident->state < sizeof(head) &&
>> 
>> 		// minus one because otherwise we'd compare the
>> 		// terminating NUL as well even though we're not
>> 		// actually looking for a NUL
>> 		if (ident->state < sizeof(head) - 1 &&
>
> Possibly, but that doesn't matter, as the right number of characters is
> remembered and the second test below is not passed if we sailed past the
> NUL.  Sorry for the noise.
Thanks for a careful reading.

In the second re-roll, I'll split the cascade and ident into two patches (ident comes first, with a fake cascade that returns NULL to indicate there is no cascading supported when two "real" filters are given). Also I do not need two buffers in the cascade. The input to cascade can be fed directly to the input of cascade->one to fill the cascade's buffer, and we can feed cascade->two with what is in the cascade's buffer to directly drain to the output of the cascade.

But that won't happen today.
Previous: René Scharfe
Message 12 of 12 in “streaming conversion API”
  1. 0/4 streaming conversion APIJunio C Hamano, May 21, 2011
  2. convert.h: move declarations for conversion from cache.hJunio C Hamano, May 21, 2011
  3. 2/4 Add streaming filter APIJunio C Hamano, May 21, 2011
  4. 3/4 Add LF-to-CRLF streaming conversionJunio C Hamano, May 21, 2011
  5. 4/4 streaming filter: ident filter and filter cascadingJunio C Hamano, May 21, 2011
  6. René ScharfeMay 21, 2011
  7. René ScharfeMay 21, 2011
  8. Junio C HamanoMay 25, 2011
  9. t0021: test application of both crlf and identJunio C Hamano, May 25, 2011
  10. streaming: filter cascadingJunio C Hamano, May 25, 2011
  11. René ScharfeMay 21, 2011
  12. Junio C HamanoMay 22, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.