Re: [PATCH v2] Make use of git status when autocompleting git add, rm, checkout --, and reset HEAD
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 30, 2011, 23:14 UTC
- Message-ID
- <7v1uw21ogf.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1314740583-14567-1-git-send-email-panduwana@gmail.com>
Ron Panduwana <panduwana@gmail.com> writes:
> Signed-off-by: Ron Panduwana <panduwana@gmail.com>
"Make use of" is something anybody can read from the patch. What we need from the proposed commit log message above S-o-b: line is to justify why it is a good change. Does it make the code simpler to follow by making it shorter? Does it make it faster to complete, and if so by how much faster? Does it make it easier to use by not including paths that it used to show, and if so what are the differences the end users would see, and why is it justified to omit these paths from the candidate set?