Re: [PATCH/RFCv3 2/2] receive-pack: don't pass non-existent refs to post-{receive,update} hooks in push deletions
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 30, 2011, 18:19 UTC
- Message-ID
- <7v1uuxq4er.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20110930132903.GA1622@myhost>
Pang Yan Han <pangyanhan@gmail.com> writes:
> Sorry for asking, but do I need to reroll this with the fixup in > origin/ph/push-to-delete-nothing ? Is the commit message fine especially > in light of the changes in the fixup?
If you think that the result of squashing the fix-up commit into your patch looks OK, I do not think there is a need to reroll. The patch title may need to be shortened, but other than that I do not see anything glaringly wrong in the commit log message that I cannot amend out.
Thanks.