Re: [PATCH] Implement ACL module architecture and sample MySQL ACL module

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 14, 2012, 16:12 UTC
Message-ID: <7v1uj98nbj.fsf@alter.siamese.dyndns.org>
In-Reply-To: <feafacf49186d7cf0eed0002a82289b318f56ff8.1344938189.git.minovotn@redhat.com>

Michal Novotny <minovotn@redhat.com> writes:

> Hi,
> this is the patch to introduce the ACL module architecture into git
> versioning system.

No, it doesn't. It adds something only to "git daemon", but does not affect any other uses of Git.

    Side note: I am not saying other uses of Git must be ACL
    controlled by MySQL database.  They shouldn't be.  I am only
    saying that the proposed commit log message must match what the
    change does.

Please familiarize yourself with Documentation/SubmittingPatches first, and then imitate the style in existing commits in the history and posted patches by the "good" developers (you can tell who they are by observing the list traffic for a few weeks), by the way.

As "git daemon" already has a mechanism to specify what repositories are served with whitelist or blacklist, I am not sure if this patch adds enough value to the system to make us want to add further complexity only to carry more code to be audited for security.

Opinions?