Re: [PATCH] git-am: fix "Applying" message when applypatch-hook was run

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 20, 2013, 23:52 UTC
Message-ID: <7v1ub9d3xw.fsf@alter.siamese.dyndns.org>
In-Reply-To: <vpqli9hmyov.fsf@grenoble-inp.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

Show 9 quoted lines

> Please, read SubmittingPatches in the Documentation directory of Git's
> source tree. Your text above should be a commit message (hence, no
> hello), and should not be below the --- line.
>
> Also, read about signed-off-by in the same document.
> ...
> This copy/paste a piece of code that is already a few lines above. Is
> there any reason not to _move_ the assignment to FIRSTLINE after the "if
> test -x "$GIT_DIR"/hooks/applypatch-msg", to avoid duplicating?

More importantly, is this change even desirable?

The original motivation behind the "Applying:" message was to help the user identify which one of the 100+ patches being fed to the command, and it was not about showing what we ended up committing. When you are running the command interactively, we do grab the edited result since f23272f3fd84 (git-am -i: report rewritten title, 2007-12-04), but I tend to feel that the automated munging done by applypatch-msg falls into a different category.