git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] branch: rework the descriptions of rename and copy operations

From
DSDragan Simic <dsimic@manjaro.org>
Date
Feb 16, 2024, 21:58 UTC
Message-ID
<7fc9dddac54d09f706419c903911a73c@manjaro.org>
In-Reply-To
<xmqqh6i8gk20.fsf@gitster.g>
On 2024-02-16 22:45, Junio C Hamano wrote:
Show 15 quoted lines
> Dragan Simic <dsimic@manjaro.org> writes:
> 
>>> But the halfway modification to the description section in this
>>> patch is not an improvement.  It makes some options described there
>>> while -m and -c are completely missing now, making the section
>>> incomplete and coverage of the operating modes of the command
>>> uneven.
>> 
>> If I got it right, you'd prefer this patch not to be accepted
>> separately, but as part of the future series that would rework the
>> entire git-branch(1) man page?  I'm fine with that as well.
> 
> Not necessarily.  If you wanted to this this in multiple steps, we
> can first whip the OPTIONS part into a good shape, and then fix the
> DESCRIPTION part.

I'll think a bit more about it, to see what might be our best choice moving forward.

Show 6 quoted lines
> What we want to avoid (not limited to this topic) is to say "this
> temporarily makes things worse here, but trust me it will eventually
> become perfect".  Removing only -m/-c from the description section
> makes the description section worse than before the patch---we'd be
> better off leaving the original as-is if we are not revamping the
> entire section.

The way you wrote this brought a smile to my face. :) I agree, making things a bit worse while promising perfection later is rarely justified. Perhaps only when some nasty bug has to be fixed ASAP.

Previous: Junio C Hamano
Message 5 of 5 in “branch: rework the descriptions of rename and copy operations”
  1. branch: rework the descriptions of rename and copy operationsDragan Simic, Feb 16, 2024
  2. Junio C HamanoFeb 16, 2024
  3. Dragan SimicFeb 16, 2024
  4. Junio C HamanoFeb 16, 2024
  5. Dragan SimicFeb 16, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.