Re: [PATCH v2 2/7] merge-ort: add some more explanations in collect_merge_info_callback()
- From
Bagas Sanjaya <bagasdotme@gmail.com>
- Date
- Jul 13, 2021, 23:34 UTC
- Message-ID
- <7f4fc9f6-9b46-6e39-1a66-b72e0c583f21@gmail.com>
- In-Reply-To
- <8aea3713902b7d006f527ccd76faf6f944529bdb.1626204784.git.gitgitgadget@gmail.com>
On 14/07/21 02.32, Elijah Newren via GitGitGadget wrote:
Show 11 quoted lines
> @@ -1018,8 +1018,8 @@ static int collect_merge_info_callback(int n,
> if (side1_matches_mbase && side2_matches_mbase) {
> /* mbase, side1, & side2 all match; use mbase as resolution */
> setup_path_info(opt, &pi, dirname, info->pathlen, fullpath,
> - names, names+0, mbase_null, 0,
> - filemask, dirmask, 1);
> + names, names+0, mbase_null, 0 /* df_conflict */,
> + filemask, dirmask, 1 /* resolved */);
> return mask;
> }
>Is df_conflict stands for directory-file conflict?
Show 11 quoted lines
> /* > - * Record information about the path so we can resolve later in > - * process_entries. > + * None of the special cases above matched, so we have a > + * provisional conflict. (Rename detection might allow us to > + * unconflict some more cases, but that comes later so all we can > + * do now is record the different non-null file hashes.) > */ > setup_path_info(opt, &pi, dirname, info->pathlen, fullpath, > names, NULL, 0, df_conflict, filemask, dirmask, 0); >
So when none of special cases matched, we assumed there's conflict (although provisional), right?
-- An old man doll... just what I always wanted! - Clara