Re: Commit graph not using minimal number of columns

From: Derrick Stolee <derrickstolee@github.com>
Date: Apr 27, 2023, 13:02 UTC
Message-ID: <7ec7f7b2-3e7a-afb9-7042-a4375970e8d8@github.com>
In-Reply-To: <xmqqwn1ysfo4.fsf@gitster.g>

On 4/26/2023 1:43 PM, Junio C Hamano wrote:

Show 13 quoted lines

> Derrick Stolee <derrickstolee@github.com> writes:
> 
>> To adapt this algorithm to a newer, dynamic ordering that cares about
>> minimizing the rendered graph, I don't think changing the priority
>> queue comparison would be sufficient. Something deeper would be
>> required and would be quite messy.
> 
> Oh, I wasn't thinking about "graph-friendly" at all.  
> 
> I was wondering if we replaced --date-order implementation with
> corrected commit date from the generation number work would give us
> a better output order that users would expect in general (with or
> without --graph).

Ah. My mistake.

Corrected commit date should be equal to commit date unless there is clock skew causing a commit to be older than its parent, (or we have a path of commits with equal commit date) so I don't anticipate that being helpful in general.

Thanks, -Stolee