git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 05/10] compat/posix: introduce writev(3p) wrapper

From
Johannes Sixt <j6t@kdbg.org>
Date
Mar 5, 2026, 06:39 UTC
Message-ID
<7e8b51d1-382d-47f8-be71-74e76f0c9888@kdbg.org>
In-Reply-To
<aajnZZI5yqL9CYeR@fruit.crustytoothpaste.net>
Am 05.03.26 um 03:16 schrieb brian m. carlson:
Show 12 quoted lines
> On 2026-03-05 at 00:37:45, Jeff King wrote:
>> I like that writev() can work as a drop-in replacement for write() at
>> the lowest level. But given that our main use is likely to be pkt-lines,
>> I do kind of wonder if we should just try to be more clever in forming
>> our buffers. That makes all of the portability and compat questions go
>> away (and gives the benefit to platforms that don't even have writev).
> 
> This does work and it is clever, but I think the writev is clearer and
> more explicit.  In addition, this is literally the kind of use case that
> it's designed for and the kernel will have a highly optimized
> implementation handling it.  I could also see myself making use of
> writev in my future work as well,...

Please don't. The use of writev may mislead you to depend on guarantees that a kernel implementation of writev can provide, but a compat/ implementation cannot. (For example, I read something about "the file pointer shall be unchanged" in the case of errors.) Please use simple and stupid functions (write). I highly doubt that you can squeeze out a noticable performance improvement with writev.

-- Hannes
Previous: brian m. carlsonNext: brian m. carlson
Message 26 of 53 in “upload-pack: reduce lock contention when writing packfile data”
  1. 0/2 upload-pack: reduce lock contention when writing packfile dataPatrick Steinhardt, Feb 27, 2026
  2. 1/2 upload-pack: fix debug statement when flushing packfile dataPatrick Steinhardt, Feb 27, 2026
  3. 2/2 upload-pack: reduce lock contention when writing packfile dataPatrick Steinhardt, Feb 27, 2026
  4. brian m. carlsonFeb 27, 2026
  5. Patrick SteinhardtFeb 27, 2026
  6. Junio C HamanoFeb 27, 2026
  7. Jeff KingFeb 27, 2026
  8. Patrick SteinhardtMar 2, 2026
  9. Jeff KingMar 2, 2026
  10. Patrick SteinhardtMar 3, 2026
  11. Jeff KingMar 3, 2026
  12. Patrick SteinhardtMar 3, 2026
  13. 00/10 upload-pack: reduce lock contention when writing packfile dataPatrick Steinhardt, Mar 3, 2026
  14. 01/10 upload-pack: fix debug statement when flushing packfile dataPatrick Steinhardt, Mar 3, 2026
  15. 02/10 upload-pack: adapt keepalives based on bufferingPatrick Steinhardt, Mar 3, 2026
  16. Jeff KingMar 5, 2026
  17. Patrick SteinhardtMar 10, 2026
  18. 03/10 upload-pack: reduce lock contention when writing packfile dataPatrick Steinhardt, Mar 3, 2026
  19. Jeff KingMar 5, 2026
  20. Patrick SteinhardtMar 10, 2026
  21. 04/10 git-compat-util: introduce `cast_size_t_to_ssize_t()`Patrick Steinhardt, Mar 3, 2026
  22. 05/10 compat/posix: introduce writev(3p) wrapperPatrick Steinhardt, Mar 3, 2026
  23. Junio C HamanoMar 4, 2026
  24. Jeff KingMar 5, 2026
  25. brian m. carlsonMar 5, 2026
  26. Johannes SixtMar 5, 2026
  27. brian m. carlsonMar 5, 2026
  28. Patrick SteinhardtMar 10, 2026
  29. 06/10 wrapper: introduce writev(3p) wrappersPatrick Steinhardt, Mar 3, 2026
  30. 07/10 sideband: use writev(3p) to send pktlinesPatrick Steinhardt, Mar 3, 2026
  31. Junio C HamanoMar 4, 2026
  32. 08/10 csum-file: introduce `hashfd_ext()`Patrick Steinhardt, Mar 3, 2026
  33. Junio C HamanoMar 4, 2026
  34. Patrick SteinhardtMar 10, 2026
  35. 09/10 csum-file: drop `hashfd_throughput()`Patrick Steinhardt, Mar 3, 2026
  36. 10/10 builtin/pack-objects: reduce lock contention when writing packfile dataPatrick Steinhardt, Mar 3, 2026
  37. 00/10 upload-pack: reduce lock contention when writing packfile dataPatrick Steinhardt, Mar 10, 2026
  38. 01/10 upload-pack: fix debug statement when flushing packfile dataPatrick Steinhardt, Mar 10, 2026
  39. 02/10 upload-pack: adapt keepalives based on bufferingPatrick Steinhardt, Mar 10, 2026
  40. 03/10 upload-pack: prefer flushing data over sending keepalivePatrick Steinhardt, Mar 10, 2026
  41. Junio C HamanoMar 10, 2026
  42. Patrick SteinhardtMar 10, 2026
  43. 04/10 upload-pack: reduce lock contention when writing packfile dataPatrick Steinhardt, Mar 10, 2026
  44. 05/10 compat/posix: introduce writev(3p) wrapperPatrick Steinhardt, Mar 10, 2026
  45. Junio C HamanoMar 10, 2026
  46. 06/10 wrapper: introduce writev(3p) wrappersPatrick Steinhardt, Mar 10, 2026
  47. 07/10 sideband: use writev(3p) to send pktlinesPatrick Steinhardt, Mar 10, 2026
  48. 08/10 csum-file: introduce `hashfd_ext()`Patrick Steinhardt, Mar 10, 2026
  49. 09/10 csum-file: drop `hashfd_throughput()`Patrick Steinhardt, Mar 10, 2026
  50. 10/10 builtin/pack-objects: reduce lock contention when writing packfile dataPatrick Steinhardt, Mar 10, 2026
  51. Junio C HamanoMar 10, 2026
  52. Johannes SixtMar 10, 2026
  53. Patrick SteinhardtMar 11, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.